Passing the link of empack_env_meta.json file #120
Merged
+126
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Sep 26, 2024
martinRenou
reviewed
Sep 27, 2024
trungleduc
force-pushed
the
custom_loading_packages
branch
from
5a323b4
to
9ca175f
Compare
trungleduc
force-pushed
the
custom_loading_packages
branch
from
9ca175f
to
0c68668
Compare
|
CI is green! |
martinRenou
requested changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the part of the solution of https://github.com/QuantStack/qs.ai/issues/28
It includes next changes:
empack_env_metafrom search url params and this parameter contains a link where empack_env_meta.json file is hosted.It should be used with emscripten-forge/pyjs#74 together